[PATCH] D46421: [analyzer][CrossTU] Extend CTU to VarDecls with initializer

[Rafael Stahl via Phabricator via cfe-commits]

r.stahl marked 3 inline comments as done.
r.stahl added a comment.

In D46421#1456171 <https://reviews.llvm.org/D46421#1456171>, @xazax.hun wrote:

> My last set of comments are also unresolved. Most of them are minor nits, but I would love to get rid of the code duplication between ClangExtDefMapGen and the Clang Static Analyzer regarding when do we consider a variable worth to import. Otherwise the patch looks good to me.


Sorry, was too long ago, thought this was done!

What would be a good place for this? I'm thinking ExprClassification in the AST lib. There is a tail in `IsModifiable` that tests the `CanQualType` for const that could be moved out. And then make a new function `bool ContainsConst(const VarDecl *VD)` mabye? Shouldn't that be a new patch, because it touches the more critical AST lib?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D46421/new/

https://reviews.llvm.org/D46421