[PATCH] D59932: [clang-tidy] **Prototype**: Add fix description to clang-tidy checks.
Haojian Wu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Apr 5 05:17:24 PDT 2019
hokein added inline comments.
================
Comment at: clang/include/clang/Tooling/Core/Diagnostic.h:67-71
+ // Get the chosen fix to apply for this diagnostic.
+ // FIXME: currently we choose the first non-empty fix, extend it to support
+ // fix selection.
+ const llvm::StringMap<Replacements> *getChosenFix() const;
+
----------------
alexfh wrote:
> Do we actually need this method here? This whole structure is sort of a data-only serialization helper, and this method is adding some (arbitrary) logic into it.
We have a few places using this method, or we could move this method out of this structure?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59932/new/
https://reviews.llvm.org/D59932
More information about the cfe-commits
mailing list