[PATCH] D59744: Fix i386 ABI "__m64" type bug

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 4 14:53:04 PDT 2019


rnk added inline comments.


================
Comment at: lib/CodeGen/TargetInfo.cpp:9473-9474
           IsWin32FloatStructABI, CodeGenOpts.NumRegisterParameters));
+    } else if (Triple.getOS() == llvm::Triple::Linux) {
+      // System V i386 ABI requires __m64 value passing by MMX registers.
+      bool EnableMMX = getContext().getTargetInfo().getABI() != "no-mmx";
----------------
The Sys V rules apply to every non-Windows OS, not just Linux. I think you should add the parameter regardless of the OS


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59744/new/

https://reviews.llvm.org/D59744





More information about the cfe-commits mailing list