[PATCH] D60263: [clang-format] Preserve include blocks in ObjC Google style

Thu Apr 4 06:34:01 PDT 2019

krasimir marked 2 inline comments as done.
krasimir added inline comments.

================
Comment at: lib/Format/Format.cpp:787
   GoogleStyle.IncludeStyle.IncludeIsMainRegex = "([-_](test|unittest))?$";
   GoogleStyle.IncludeStyle.IncludeBlocks = tooling::IncludeStyle::IBS_Regroup;
   GoogleStyle.IndentCaseLabels = true;
----------------
ioeric wrote:
> maybe we should also only use regroup for cpp? `regroup` is only supported in `sortCppIncludes` after all.
Yeah, but they are just not used for unrelated languages. This argument applies to the other fields in the IncludeStyle group above this. I'd lean on keeping this as-is.

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60263/new/

https://reviews.llvm.org/D60263