[PATCH] D60235: [CMake] Disable libc++ and libc++abi new/delete definitions when built with ASan
Petr Hosek via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Apr 3 15:56:57 PDT 2019
phosek added a subscriber: ldionne.
phosek added a comment.
In D60235#1454152 <https://reviews.llvm.org/D60235#1454152>, @mcgrathr wrote:
> IMHO the library code should use `#if !__has_feature(...)` to avoid the definitions entirely when built with a sanitizer whose runtime provides them.
> But this is a fine way to achieve that while we wait for those libraries to be fixed for sanitized builds.
I agree, D60176 <https://reviews.llvm.org/D60176> implements that but @ldionne thinks that we should go with the CMake option.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60235/new/
https://reviews.llvm.org/D60235
More information about the cfe-commits
mailing list