[PATCH] D59347: [DebugInfo] Combine Trivial and NonTrivial flags

Hui Huang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 3 14:22:50 PDT 2019


Hui added inline comments.


================
Comment at: test/CodeGenCXX/debug-info-composite-triviality.cpp:88
-
-// CHECK-DAG: !DICompositeType({{.*}}, name: "NonTrivialE",{{.*}}flags: {{.*}}DIFlagNonTrivial
-struct NonTrivialE : Trivial, NonTrivial {
----------------
probinson wrote:
> This one used to be flagged nontrivial, and now it's not flagged?
The base struct 'Trivial' was removed  and this case became duplicated since it is now similar with 'struct NonTrivialD'. Could be very easy to add it back per request.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59347/new/

https://reviews.llvm.org/D59347





More information about the cfe-commits mailing list