[PATCH] D60199: [clang-format] Do not emit replacements while regrouping if Cpp includes are OK
Eric Liu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Apr 3 07:40:38 PDT 2019
ioeric added inline comments.
================
Comment at: unittests/Format/SortIncludesTest.cpp:28
std::string sort(StringRef Code, std::vector<tooling::Range> Ranges,
+ llvm::Optional<unsigned> ExpectedNumRanges = llvm::None,
StringRef FileName = "input.cc") {
----------------
As most cases would pass `1`, maybe it would make sense to make this a class member that defaults to `1`? It can be explicitly set in specific tests when needed.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60199/new/
https://reviews.llvm.org/D60199
More information about the cfe-commits
mailing list