[PATCH] D59628: Add support for __attribute__((objc_class_stub))
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Apr 3 07:27:57 PDT 2019
aaron.ballman added inline comments.
================
Comment at: include/clang/Basic/AttrDocs.td:1116
+def ObjCClassStubDocs : Documentation {
+ let Category = DocCatFunction;
+ let Content = [{
----------------
aaron.ballman wrote:
> slavapestov wrote:
> > aaron.ballman wrote:
> > > This seems like the wrong category -- the attribute doesn't apply to functions.
> > Would DocCatType make more sense? Would you like me to change ObjCRuntimeVisible and a handful of other miscategorized attributes too?
> Oye, it looks like we have a lot of inconsistent categories currently. It's not really a type attribute, it's a declaration attribute, but we don't have such a notion yet. Go ahead and leave this as `DocCatType` for now; I'll see about cleaning this up in a follow-up.
I added `DocCatDecl` in r357585, which I think would be the correct category to use here.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59628/new/
https://reviews.llvm.org/D59628
More information about the cfe-commits
mailing list