[PATCH] D59919: [Attributor] Deduce "returned" argument attribute

Johannes Doerfert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 1 08:08:56 PDT 2019


jdoerfert marked an inline comment as done.
jdoerfert added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:394
+
+        indicateFixpoint(/* Optimistic */ true);
+        return;
----------------
xbolva00 wrote:
> Maybe enum here ?
> So you could call indicateFixpoint(Fixpoint::optimistic) ?
> 
> Or maybe even better, indicateOptimisticFixpoint()?
Good points. I'll probably go with the second, most explicit, solution. I'll update (all) the source files soon.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59919/new/

https://reviews.llvm.org/D59919





More information about the cfe-commits mailing list