[PATCH] D59802: [clang-tidy] Add new checker: llvm-avoid-cast-in-conditional

Mon Apr 1 07:38:09 PDT 2019

aaron.ballman added inline comments.

================
Comment at: clang-tools-extra/clang-tidy/utils/HeaderFileExtensionsUtils.h:21

-typedef llvm::SmallSet<llvm::StringRef, 5> HeaderFileExtensionsSet;
+using HeaderFileExtensionsSet = ::llvm::SmallSet<StringRef, 5>;

----------------
hintonda wrote:
> aaron.ballman wrote:
> > Can you add back the `::llvm::` qualifier on the `StringRef` type?
> I could do that, but do you mean just this case of StringRef, of all four?  And what about SourceLocation and SourceManager?
If any changes are needed in this file at all, I'd prefer to keep them minimal and self-consistent, so only this instance. However, I wouldn't be opposed to a consistency cleanup in this file as a separate patch with NFC.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59802/new/

https://reviews.llvm.org/D59802