[PATCH] D59449: [clang-tidy] Integrate clang-tidy-diff.py machinery into run-clang-tidy.py

Mon Apr 1 04:46:05 PDT 2019

alexfh added a comment.

In D59449#1435836 <https://reviews.llvm.org/D59449#1435836>, @zinovy.nis wrote:

> In D59449#1435032 <https://reviews.llvm.org/D59449#1435032>, @alexfh wrote:
>
> > How is this functionality different from the clang-tidy-diff.py script with the -j option being added in the other patch?
>
>
> It's the same.

Why not just use clang-tidy-diff.py? The clang-tidy-diff.py script has a distinct and somewhat self-documenting name and a very specific purpose (find clang-tidy regressions in a patch), while run-clang-tidy.py is more focused on running over larger bodies of code with a purpose of analyzing or cleaning up. Is there any benefit in having all functionality in run-clang-tidy.py?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59449/new/

https://reviews.llvm.org/D59449