[PATCH] D58497: Clear the KnownModules cache if the preprocessor is going away

Sun Mar 31 08:54:57 PDT 2019

dblaikie added a comment.

In D58497#1449243 <https://reviews.llvm.org/D58497#1449243>, @nemanjai wrote:

> Ping.

Unfortunately Richard Smith is out for a few weeks at the moment, so might take a little bit before he can get to this.

It's odd to me that this lacks a test case - but you mention it's shown up on buildbots? Does it reproduce consistently there? Under what conditions (which buildbots/configurations show this - are they permanently failing because of this?)?

A test case, if at all possible, would be super helpful.

> If there are no objections in the next week or so, I'll commit this and it can be reviewed post-commit.

That's generally not considered acceptable practice - if something is sent for review it's because it needs review & time doesn't change that. (there are some exceptions to this - some folks send things out for "hey, anyone got other ideas on this, otherwise I think it's fine" sort of thing)

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58497/new/

https://reviews.llvm.org/D58497