[PATCH] D60038: gn build: Add build files for most clang-tools-extra unit tests

Sun Mar 31 05:46:05 PDT 2019

mbonadei accepted this revision.
mbonadei added a comment.
This revision is now accepted and ready to land.

LGTM, just a small style comment.

================
Comment at: llvm/utils/gn/secondary/clang-tools-extra/unittests/clang-apply-replacements/BUILD.gn:3
+
+unittest("ClangApplyReplacementsTests") {
+  configs += [ "//llvm/utils/gn/build:clang_code" ]
----------------
Why don't we use `output_name` here as well? It seems to be available for executables (https://gn.googlesource.com/gn/+/master/docs/reference.md#target-declarations-executable_declare-an-executable-target-variables). The current style seems to be lisp-case for target names and have `output_name` matching the cmake build.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60038/new/

https://reviews.llvm.org/D60038