[PATCH] D59934: Compare SourceLocations from different TUs by FileID

Sat Mar 30 15:41:50 PDT 2019

gamesh411 added a comment.

In D59934#1446736 <https://reviews.llvm.org/D59934#1446736>, @Szelethus wrote:

> In D59934#1446051 <https://reviews.llvm.org/D59934#1446051>, @gamesh411 wrote:
>
> > Hi!
> >
> > This issue came up during the generation BugReports of BugPaths containing macro-expansions, where the spelling location and expansion locations were in different files.
> >  With this change, we make such SourceLocations comparable by their FileIDs.
>
>
> Do you mean regular macro expansions or the one we're generating in the plist output via `-analyzer-config expand-macros=true`?

I have confirmed, that this happens when -analyzer-config expand-macros=true is passed, and no unreachable line is triggered without this analyzer config.

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59934/new/

https://reviews.llvm.org/D59934