[PATCH] D60029: Add const children() accessors to Stmts
Bruno Ricci via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sat Mar 30 11:28:38 PDT 2019
riccibruno added a comment.
In D60029#1448944 <https://reviews.llvm.org/D60029#1448944>, @nicolas wrote:
> In D60029#1448938 <https://reviews.llvm.org/D60029#1448938>, @riccibruno wrote:
>
> > Did you go over all the statements on `Stmt.h` systematically ?
>
>
> Yes.
>
> > You could also do the same thing for all of the statements/expressions in `StmtCXX.h`, `Expr.h`, `ExprCXX.h`, and so on.
>
> I will go over those soon. I believe that `Expr.h` is mostly done.
>
> > Apart from this did you run `clang-format` on the patch ?
>
> I tried to stick to the style of the non-const functions, even when it was wrong. I will `clang-format` the next patch!
Ah I see. Yeah I know that a fair amount of code is not formatted unfortunately.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60029/new/
https://reviews.llvm.org/D60029
More information about the cfe-commits
mailing list