[PATCH] D60023: [libcxx] [test] Fix inability to rebind poca_alloc in string.cons/copy_alloc.pass.cpp.
Billy Robert O'Neal III via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sat Mar 30 02:51:28 PDT 2019
BillyONeal marked an inline comment as done.
BillyONeal added inline comments.
================
Comment at: test/std/strings/basic.string/string.cons/copy_alloc.pass.cpp:125
test_assign(s1, s2);
assert(s1 == p1);
assert(s2 == p2);
----------------
This particular assert tests that the copy assignment operator provides the strong exception safety guarantee, but the standard requires only the basic guarantee. Should this be _LIBCXX_ASSERT?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60023/new/
https://reviews.llvm.org/D60023
More information about the cfe-commits
mailing list