[PATCH] D59827: [slh] x86 impl of ARM instrinsic for SLH

[Zola Bridges via Phabricator via cfe-commits]

zbrid marked 2 inline comments as done.
zbrid added inline comments.


================
Comment at: llvm/lib/Target/X86/X86SpeculativeLoadHardening.cpp:614-628
+      if (Opcode == X86::SpeculationSafeValue32) {
+        BuildMI(MBB, NMBBI, DebugLoc(), TII->get(X86::LFENCE));
+        ++NumInstsInserted;
+        ++NumLFENCEsInserted;
+        MRI->replaceRegWith(MI.getOperand(0).getReg(), MI.getOperand(1).getReg());
+        MI.eraseFromParent();
+        Modified = true;
----------------
kristof.beyls wrote:
> The lowering of the intrinsic on a 32 bit and a 64 bit value looks identical to me, so the if statement isn't needed?
Good catch. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59827/new/

https://reviews.llvm.org/D59827