[PATCH] D59725: Additions to creduce script

[Amy Huang via Phabricator via cfe-commits]

akhuang marked 2 inline comments as done.
akhuang added inline comments.


================
Comment at: clang/utils/creduce-clang-crash.py:208
+    print("\nTrying to preprocess the source file...")
+    # use delete=False in case the tmpfile flag causes problems when copying
+    with tempfile.NamedTemporaryFile(delete=False) as tmpfile:
----------------
arichardson wrote:
> I believe we are currently not deleting this temporary file.
> Can `delete=False` be removed since we are using `shutil.copy()` instead of a move?
> 
Yeah, I think that should be fine. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59725/new/

https://reviews.llvm.org/D59725