r357255 - clang-cl: Expose -fprofile-generate and -fcs-profile-generate (PR41252)

[Hans Wennborg via cfe-commits]

I guess it's not really needed, but I'm also not sure how much we want
users to have to rely on the /clang: flag.

On Fri, Mar 29, 2019 at 3:43 PM Nico Weber via cfe-commits
<cfe-commits at lists.llvm.org> wrote:
>
> Do we still need changes like this now that we have the /clang: switch?
>
> On Fri, Mar 29, 2019 at 10:02 AM Hans Wennborg via cfe-commits <cfe-commits at lists.llvm.org> wrote:
>>
>> Author: hans
>> Date: Fri Mar 29 07:03:34 2019
>> New Revision: 357255
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=357255&view=rev
>> Log:
>> clang-cl: Expose -fprofile-generate and -fcs-profile-generate (PR41252)
>>
>> Modified:
>>     cfe/trunk/include/clang/Driver/Options.td
>>     cfe/trunk/test/Driver/cl-options.c
>>
>> Modified: cfe/trunk/include/clang/Driver/Options.td
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/Options.td?rev=357255&r1=357254&r2=357255&view=diff
>> ==============================================================================
>> --- cfe/trunk/include/clang/Driver/Options.td (original)
>> +++ cfe/trunk/include/clang/Driver/Options.td Fri Mar 29 07:03:34 2019
>> @@ -742,16 +742,16 @@ def fno_coverage_mapping : Flag<["-"], "
>>      Group<f_Group>, Flags<[DriverOption, CoreOption]>,
>>      HelpText<"Disable code coverage analysis">;
>>  def fprofile_generate : Flag<["-"], "fprofile-generate">,
>> -    Group<f_Group>, Flags<[DriverOption]>,
>> +    Group<f_Group>, Flags<[CoreOption]>,
>>      HelpText<"Generate instrumented code to collect execution counts into default.profraw (overridden by LLVM_PROFILE_FILE env var)">;
>>  def fprofile_generate_EQ : Joined<["-"], "fprofile-generate=">,
>> -    Group<f_Group>, Flags<[DriverOption]>, MetaVarName<"<directory>">,
>> +    Group<f_Group>, Flags<[CoreOption]>, MetaVarName<"<directory>">,
>>      HelpText<"Generate instrumented code to collect execution counts into <directory>/default.profraw (overridden by LLVM_PROFILE_FILE env var)">;
>>  def fcs_profile_generate : Flag<["-"], "fcs-profile-generate">,
>> -    Group<f_Group>, Flags<[DriverOption]>,
>> +    Group<f_Group>, Flags<[CoreOption]>,
>>      HelpText<"Generate instrumented code to collect context sensitive execution counts into default.profraw (overridden by LLVM_PROFILE_FILE env var)">;
>>  def fcs_profile_generate_EQ : Joined<["-"], "fcs-profile-generate=">,
>> -    Group<f_Group>, Flags<[DriverOption]>, MetaVarName<"<directory>">,
>> +    Group<f_Group>, Flags<[CoreOption]>, MetaVarName<"<directory>">,
>>      HelpText<"Generate instrumented code to collect context sensitive execution counts into <directory>/default.profraw (overridden by LLVM_PROFILE_FILE env var)">;
>>  def fprofile_use : Flag<["-"], "fprofile-use">, Group<f_Group>,
>>      Alias<fprofile_instr_use>;
>> @@ -759,13 +759,13 @@ def fprofile_use_EQ : Joined<["-"], "fpr
>>      Group<f_Group>, Flags<[DriverOption]>, MetaVarName<"<pathname>">,
>>      HelpText<"Use instrumentation data for profile-guided optimization. If pathname is a directory, it reads from <pathname>/default.profdata. Otherwise, it reads from file <pathname>.">;
>>  def fno_profile_instr_generate : Flag<["-"], "fno-profile-instr-generate">,
>> -    Group<f_Group>, Flags<[DriverOption]>,
>> +    Group<f_Group>, Flags<[CoreOption]>,
>>      HelpText<"Disable generation of profile instrumentation.">;
>>  def fno_profile_generate : Flag<["-"], "fno-profile-generate">,
>> -    Group<f_Group>, Flags<[DriverOption]>,
>> +    Group<f_Group>, Flags<[CoreOption]>,
>>      HelpText<"Disable generation of profile instrumentation.">;
>>  def fno_profile_instr_use : Flag<["-"], "fno-profile-instr-use">,
>> -    Group<f_Group>, Flags<[DriverOption]>,
>> +    Group<f_Group>, Flags<[CoreOption]>,
>>      HelpText<"Disable using instrumentation data for profile-guided optimization">;
>>  def fno_profile_use : Flag<["-"], "fno-profile-use">,
>>      Alias<fno_profile_instr_use>;
>>
>> Modified: cfe/trunk/test/Driver/cl-options.c
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/cl-options.c?rev=357255&r1=357254&r2=357255&view=diff
>> ==============================================================================
>> --- cfe/trunk/test/Driver/cl-options.c (original)
>> +++ cfe/trunk/test/Driver/cl-options.c Fri Mar 29 07:03:34 2019
>> @@ -630,6 +630,13 @@
>>  // RUN:     -no-canonical-prefixes \
>>  // RUN:     -march=skylake \
>>  // RUN:     -fbracket-depth=123 \
>> +// RUN:     -fprofile-generate \
>> +// RUN:     -fprofile-generate=dir \
>> +// RUN:     -fno-profile-generate \
>> +// RUN:     -fno-profile-instr-generate \
>> +// RUN:     -fno-profile-instr-use \
>> +// RUN:     -fcs-profile-generate \
>> +// RUN:     -fcs-profile-generate=dir \
>>  // RUN:     --version \
>>  // RUN:     -Werror /Zs -- %s 2>&1
>>
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at lists.llvm.org
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits