[PATCH] D59900: [Sema] Fix a crash when nonnull checking

[Nicolas Lesser via Phabricator via cfe-commits]

Rakete1111 accepted this revision.
Rakete1111 added a comment.
This revision is now accepted and ready to land.

Otherwise LGTM.



================
Comment at: clang/test/SemaTemplate/decltype.cpp:1
+// RUN: %clang_cc1 -std=c++11 -fsyntax-only -verify %s
+// no crash & no diag
----------------
test/SemaCXX/nonnull.cpp would be a better place to put this test.


================
Comment at: clang/test/SemaTemplate/decltype.cpp:2
+// RUN: %clang_cc1 -std=c++11 -fsyntax-only -verify %s
+// no crash & no diag
+
----------------
This is redundant :)


================
Comment at: clang/test/SemaTemplate/decltype.cpp:4
+
+// expected-no-diagnostics
+template <typename T>
----------------
If you move the test as above you can drop this line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59900/new/

https://reviews.llvm.org/D59900