[PATCH] D59692: [ASTImporter] Fix name conflict handling

Aleksei Sidorin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 28 14:29:54 PDT 2019


a_sidorin added a comment.

Thanks for the fixes! I'd like to clarify one moment, however.



================
Comment at: lib/AST/ASTImporter.cpp:2154
+        return NameOrErr.takeError();
     }
   }
----------------
Should we write `else Name = *NameOrError`?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59692/new/

https://reviews.llvm.org/D59692





More information about the cfe-commits mailing list