[PATCH] D59899: gn build: Add some build files for clangd

[Mirko Bonadei via Phabricator via cfe-commits]

mbonadei accepted this revision.
mbonadei added a comment.
This revision is now accepted and ready to land.

Sorry for the delay, LGTM % 2 small comments.



================
Comment at: llvm/utils/gn/secondary/clang-tools-extra/clang-apply-replacements/BUILD.gn:2
 static_library("clang-apply-replacements") {
+  output_name = "clangApplyReplacements"
   configs += [ "//llvm/utils/gn/build:clang_code" ]
----------------
Oh, I forgot to add this! Thanks!


================
Comment at: llvm/utils/gn/secondary/clang-tools-extra/clangd/BUILD.gn:32
+    "//clang/lib/Serialization",
+    "//clang/lib/Tooling/Core",
+    "//clang/lib/Tooling/Inclusions",
----------------
Missing //clang/lib/Tooling ?


================
Comment at: llvm/utils/gn/secondary/clang-tools-extra/clangd/refactor/tweaks/BUILD.gn:7
+  configs += [ "//llvm/utils/gn/build:clang_code" ]
+  deps = [
+    "//clang-tools-extra/clangd",
----------------
Missing "//llvm/lib/Support"?

Probably it is ok, since it is a `source_set`, but am I following the 1:1 matching rule.


================
Comment at: llvm/utils/gn/secondary/clang-tools-extra/clangd/tool/BUILD.gn:9
+write_cmake_config("features") {
+  # FIXME: Try moving Features.inc.in to tools, seems like a better location.
+  input = "../Features.inc.in"
----------------
+1, if that is not possible this target should be in clangd/BUILD.gn (it is more natural).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59899/new/

https://reviews.llvm.org/D59899