[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 27 17:05:49 PDT 2019


Eugene.Zelenko added inline comments.


================
Comment at: clang-tidy/abseil/WrapUniqueCheck.h:26
+private:
+ // std::string getArgs(const SourceManager *SM, const CallExpr *MemExpr);
+
----------------
Please remove obsolete commend and private keyword.


================
Comment at: docs/clang-tidy/checks/abseil-wrap-unique.rst:5
+==================
+Looks for instances of factory functions which uses a non-public constructor
+that returns a ``std::unqiue_ptr<T>`` then recommends using 
----------------
Please separate with empty line.


================
Comment at: docs/clang-tidy/checks/abseil-wrap-unique.rst:16
+  private:
+    A() {}
+  };
----------------
Please use = default;


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57435/new/

https://reviews.llvm.org/D57435





More information about the cfe-commits mailing list