[PATCH] D59863: [HIP] Support gpu arch gfx906+sram-ecc

[Artem Belevich via Phabricator via cfe-commits]

tra added inline comments.


================
Comment at: lib/Basic/Cuda.cpp:113
+  case CudaArch::GFX906_SRAM_ECC: // TBA
+    return "gfx906+sram-ecc";
   case CudaArch::GFX909: // TBA
----------------
Wording nit:
Does it mean `+(SRAM, ECC)` or `+SRAM, -ECC` ?

>From the rest of the changes I guess it's the former, but the syntax used can easily be interpreted as the later.

Perhaps change the feature name to `sram_ecc` and GPU name to something less verbose. `gfx906se` ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59863/new/

https://reviews.llvm.org/D59863