[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 27 09:55:18 PDT 2019


ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added inline comments.


================
Comment at: clang/lib/Tooling/Syntax/TokenBuffer.cpp:323
+                                              PP.getLangOpts(), Tokens);
+  auto *CB = CBOwner.get();
+
----------------
Eugene.Zelenko wrote:
> Return type is not obvious. Actually variable is used only one, so it's not necessary.
- The type is quite obvious from the previous line.
- We need the variable as we `std::move` the `unique_ptr` in the next line and sill want to access the pointer later.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59887/new/

https://reviews.llvm.org/D59887





More information about the cfe-commits mailing list