[PATCH] D58797: [Sema] Add some compile time _FORTIFY_SOURCE diagnostics

Erik Pilkington via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 26 16:20:26 PDT 2019


erik.pilkington added a comment.

In D58797#1443411 <https://reviews.llvm.org/D58797#1443411>, @efriedma wrote:

> For that particular case, I think we could suppress the false positive using DiagRuntimeBehavior.  How many total false positives are we talking about, and how many can the compiler statically prove are unreachable?


Sure, that seems like a perfect fit, I added it in r357041. There are only two false-positives IIUC, and they're both immediately guarded by an `if (sizeof(x) == sizeof(y))`.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58797/new/

https://reviews.llvm.org/D58797





More information about the cfe-commits mailing list