[PATCH] D59008: [AMDGPU] Switch default dwarf version to 5

[David Blaikie via Phabricator via cfe-commits]

dblaikie added a comment.

In D59008#1442962 <https://reviews.llvm.org/D59008#1442962>, @probinson wrote:

> In D59008#1442515 <https://reviews.llvm.org/D59008#1442515>, @dblaikie wrote:
>
> > In D59008#1442256 <https://reviews.llvm.org/D59008#1442256>, @t-tye wrote:
> >
> > > In D59008#1442014 <https://reviews.llvm.org/D59008#1442014>, @dblaikie wrote:
> > >
> > > > In D59008#1441903 <https://reviews.llvm.org/D59008#1441903>, @t-tye wrote:
> > > >
> > > > > LGTM
> > > > >
> > > > > Do we know the state of split DWARF and DWARF compression for DWARF 5 (compared to DWARF 2)?
> > > >
> > > >
> > > > State of them in what sense? Compression is pretty orthogonal to any DWARF version - it's more about the container (ELF, etc) you use. Split DWARF is non-standardly supported in pre-v5, and I think it's functioning in the standards conformant v5 mode too.
> > >
> > >
> > > I had heard mention that at least split DWARF may not be fully supported yet for DWARF 5 in LLVM. But maybe that is old news:-)
> >
> >
> > Might be - nothing I know of right now. (type units aren't fully supported in DWARFv5 - but that's the only big thing on my list)
>
>
> Anything having to do with section format and placement ought to be correct at this point.  Certainly I see v5 type units coming out in the .debug_info section per spec, and the .dwo files look right.  If there's something missing please file a bug and CC me.
>
> There was certainly a release where split-dwarf and type units didn't work yet, but that's all done now.


Ah, thanks for the correction - I thought that was the case, and then I thought I'd tested it a couple of weeks ago and seen it wasn't (when I'd expected it was)... must've messed up my test, maybe used an old compiler build I had lying around.

Good stuff!


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59008/new/

https://reviews.llvm.org/D59008