[PATCH] D59347: [DebugInfo] Combine Trivial and NonTrivial flags

David Blaikie via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 26 08:12:42 PDT 2019


dblaikie added a comment.

@asmith: Where's the LLVM-side change/review that goes with this, btw?

In D59347#1442970 <https://reviews.llvm.org/D59347#1442970>, @probinson wrote:

> As a rule I would prefer flags with positive names, as it's slightly easier to read `!isTrivial` than `!isNonTrivial`. And trivially shorter. :-)


Fair enough - I was mostly coming at this from the "the patch that was committed should be reverted" & then we could haggle over other things, but fair point.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59347/new/

https://reviews.llvm.org/D59347





More information about the cfe-commits mailing list