[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

Tue Mar 26 05:12:54 PDT 2019

Szelethus added inline comments.

================
Comment at: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:73-75
   static const unsigned InvalidArgIndex = UINT_MAX;
   /// Denotes the return vale.
   static const unsigned ReturnValueIndex = UINT_MAX - 1;
----------------
boga95 wrote:
> Szelethus wrote:
> > We should definitely change these, not only is the large integer number impossible to remember, but this value could differ on different platforms.
> I tried to use int, but I got a lot of warnings because of the `getNumArgs()` returns an unsigned value.
What warnings? I thought we have `-Wsign-conversion` disabled.

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59555/new/

https://reviews.llvm.org/D59555