[PATCH] D59665: Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName

Gabor Marton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 26 04:51:33 PDT 2019


martong added a comment.

In D59665#1442328 <https://reviews.llvm.org/D59665#1442328>, @shafik wrote:

> @martong your idea does not work b/c default construction `DeclarationName()` treats it the same as being empty. So `if (!Name)` is still `true`.


And did you try moving the `push_back` to the other scope? I'd expect the the ConflictingDecls to be empty then.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59665/new/

https://reviews.llvm.org/D59665





More information about the cfe-commits mailing list