[PATCH] D59814: [Testing] Move clangd::Annotations to llvm testing support

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 26 04:21:36 PDT 2019


ilya-biryukov marked an inline comment as done.
ilya-biryukov added a comment.

Seeking feedback for this change, mostly interested if this a good place for test helpers like this?
I'm planning to author more tests in `clangTooling` using this soon, so moving it somewhere clang-specific is an option too.



================
Comment at: llvm/include/llvm/Testing/Support/Annotations.h:42
+/// represents a half-open range.
+struct Range {
+  size_t Begin = 0;
----------------
This name is probably too generic, happy to change the name or implement this in an alternative manner.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59814/new/

https://reviews.llvm.org/D59814





More information about the cfe-commits mailing list