[PATCH] D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it

Sylvestre Ledru via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 25 11:03:42 PDT 2019


sylvestre.ledru added a comment.

@rnk btw, do you think it should be added to the clang release notes?



================
Comment at: lib/Driver/Driver.cpp:1631
-    // introduce a non-pedantically GCC compatible mode to Clang in which we
-    // provide sensible definitions for -dumpversion, __VERSION__, etc.
-    llvm::outs() << "4.2.1\n";
----------------
rnk wrote:
> We really ought to reconsider `__VERSION__` as well, although I don't think anyone checks that. Today I get this for it:
>   "4.2.1 Compatible Clang 9.0.0 (git at github.com:llvm/llvm-project.git bd6354105b055af6193fb2b7561fe6f5ae0eb0d8)"
I can have a look to that if you want


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56803/new/

https://reviews.llvm.org/D56803





More information about the cfe-commits mailing list