[PATCH] D59734: [clang-tidy] Handle missing yaml module in run-clang-tidy.py

[Zinovy Nis via Phabricator via cfe-commits]

zinovy.nis marked an inline comment as done.
zinovy.nis added inline comments.


================
Comment at: clang-tidy/tool/run-clang-tidy.py:210
+                        help='Create a yaml file to store suggested fixes in, '
+                        'which can be applied with clang-apply-replacements.')
   parser.add_argument('-j', type=int, default=0,
----------------
serge-sans-paille wrote:
> could be
> 
> ```
> if yaml:
>     parser.add_argument('-export-fixes', metavar='filename', dest='export_fixes',
> 	​                        help='Create a yaml file to store suggested fixes in, '
> 	​                        'which can be applied with clang-apply-replacements.')
> else:
>     parser.export_fixes = False
> ```
> 
> This would make later condition easier to read.
Looks strange. Not sure this works.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59734/new/

https://reviews.llvm.org/D59734