[PATCH] D59759: [clangd] Add .cu files to VSCode extension

Mon Mar 25 06:59:33 PDT 2019

hokein added a comment.

In D59759#1441349 <https://reviews.llvm.org/D59759#1441349>, @ilya-biryukov wrote:

> In D59759#1441321 <https://reviews.llvm.org/D59759#1441321>, @hokein wrote:
>
> > Do we need to add an entry `"onLanguage:cuda"` for cuda in the extension package.json?
>
>
> Yeah, sounds reasonable, but I don't see cuda in the list of languages in VSCode, nor does it auto-detect a language for `.cu` files for me.
>  Can those added by extensions (that I might be missing)? What would be the correct way to lookup all available languages?

Taking a closer look, it seems cuda is not supported by default in vscode :(

vscode provides a way to add a new language in the extension, see https://code.visualstudio.com/api/references/contribution-points#contributes.languages, we may define the cuda language in our extension, but vscode also uses this configuration to do other stuff, like syntax highlight, it seems out of scope of our extension, and I'm not sure how would it work with other cuda extension (like vscode-cudacpp which implements the cuda language).

I guess we might leave the patch as it is. clangd won't be started if vscode users only open `.cu` files; once the users open a c++ file, clangd starts, and clangd should also work for cuda files.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59759/new/

https://reviews.llvm.org/D59759