[PATCH] D59492: [OpenCL] Allow variadic macros as Clang feature

Mon Mar 25 05:20:35 PDT 2019

Anastasia marked an inline comment as done.
Anastasia added inline comments.

================
Comment at: include/clang/Basic/DiagnosticLexKinds.td:397
+def ext_pp_opencl_variadic_macros : Extension<
+  "variadic macros not supported in OpenCL">;

----------------
arsenm wrote:
> Maybe rephrase the message now to say it's an extension? The other similar warnings seem to mention "GNU extension" or "Microsoft extensions" or <standard version> extension.
> 
> None of them seem to mention "clang" extensions however.
Actually I have found a couple of diagnostics with Clang extension so it should be fine.

Thanks for the feedback.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59492/new/

https://reviews.llvm.org/D59492