[PATCH] D59761: [ASTImporter] Covert ODR diagnostics inside ASTImporter implementation

Endre Fülöp via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 25 04:28:21 PDT 2019


gamesh411 added a comment.

Hi!

During CTU analysis, not only StructuralEquivalence but the main implementation of ASTImporter can also emit ODR-related diagnostics. After some consideration, I have chosen not to make these dependent on a switch, as ASTImporter is not nearly as widely used as StructuralEquivalence (thru Sema), and it would also complicate the code unnecessarily.
What do you think?

Regards,
Endre


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59761/new/

https://reviews.llvm.org/D59761





More information about the cfe-commits mailing list