[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.
Ilya Biryukov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Mar 22 10:18:49 PDT 2019
ilya-biryukov added inline comments.
================
Comment at: clang/unittests/Tooling/TransformerTest.cpp:157
+ .as<clang::Expr>()
+ .replaceWith(text("REPLACED"))
+ .because(text("Use size() method directly on string."));
----------------
NIT: maybe consider adding overloads for these function that allow to pass char literals there? This is probably a common case, so it'd be nice to write this as:
```
replaceWith("REPLACED").because("Use size() method directly on string.");
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59376/new/
https://reviews.llvm.org/D59376
More information about the cfe-commits
mailing list