[PATCH] D59528: [clang-tidy] Expand modular headers for PPCallbacks

[Alexander Kornienko via Phabricator via cfe-commits]

alexfh added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.cpp:24
+  void recordContent(const FileEntry *File,
+                     const SrcMgr::ContentCache *ContentCache,
+                     llvm::vfs::InMemoryFileSystem &InMemoryFs) {
----------------
gribozavr wrote:
> `const &` for `File` and `ContentCache` ?
Done for `ContentCache`. The `File` is stored into a `DenseSet`, thus a pointer makes sense here.


================
Comment at: clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.cpp:171
+// Just parse to the corresponding location to generate the same callback for
+// the target_callbacks_.
+void ExpandModularHeadersPPCallbacks::Ident(SourceLocation Loc, StringRef) {
----------------
gribozavr wrote:
> What's `target_callbacks_`?  It is only mentioned in comments.
It's an artifact of an older version. Removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59528/new/

https://reviews.llvm.org/D59528