[PATCH] D59463: [ASTMatchers][OpenMP] OpenMP Structured-block-related matchers
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Mar 21 08:07:29 PDT 2019
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM aside from a NFC change
================
Comment at: include/clang/ASTMatchers/ASTMatchers.h:6444-6445
+ internal::Matcher<Stmt>, InnerMatcher) {
+ if (isStandaloneDirective().matches(Node, Finder, Builder))
+ return false; // Standalone directives have no structured blocks.
+ return InnerMatcher.matches(*Node.getStructuredBlock(), Finder, Builder);
----------------
Rather than call the matcher (which is a heavy-handed solution), I'd prefer to just check `Node.isOMPStructuredBlock()` directly.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59463/new/
https://reviews.llvm.org/D59463
More information about the cfe-commits
mailing list