[PATCH] D59467: [clang] Adding the Likely Attribute from C++2a to AST

[S. B. Tam via Phabricator via cfe-commits]

cpplearner added inline comments.


================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8166
+def err_multiple_likelihood : Error<
+  "there can only be one %0 attribue in any attribute list">;
+def err_mutuably_exclusive_likelihood : Error<
----------------
attribue => attribute


================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8172
+def note_previous_likelihood : Note<
+  "previously used %0 attribue">;
+
----------------
attribue => attribute


================
Comment at: clang/lib/Parse/ParseStmt.cpp:1329
+  } else if (ElseBranchAttr) {
+    if (ThenBranchAttr->getSpelling()[0] == 'l')
+      WhichBranch = IfStmt::ElseBranch;
----------------
Should this use `ElseBranchAttr` instead of `ThenBranchAttr`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59467/new/

https://reviews.llvm.org/D59467