[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

[Jordan Rupprecht via Phabricator via cfe-commits]

rupprecht added inline comments.


================
Comment at: cfe/trunk/unittests/AST/OMPStructuredBlockTest.cpp:58
+  std::vector<std::string> Args = {
+      "-fopenmp",
+  };
----------------
Looks like this test fails when the default is not libomp, e.g. DCLANG_DEFAULT_OPENMP_RUNTIME=libgomp
Using -fopenmp=libomp explicitly here causes the test to pass in the case. Does that seem like the right fix, or has something gone wrong?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59214/new/

https://reviews.llvm.org/D59214