[PATCH] D59533: [X86] Add __crc32b/__crc32w/__crc32d/__crc32q intrinsics to match gcc and icc.

Simon Pilgrim via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 20 06:47:43 PDT 2019


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM with one minor (doxygen desciptions)



================
Comment at: lib/Headers/ia32intrin.h:58
 
+static __inline__ unsigned int __attribute__((__always_inline__, __nodebug__, __target__("sse4.2")))
+__crc32b(unsigned int __C, unsigned char __D)
----------------
Please can you copy the doxygen comments from smmintrin.h (_mm_crc32_u8 etc.)?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59533/new/

https://reviews.llvm.org/D59533





More information about the cfe-commits mailing list