[PATCH] D59560: Permit redeclarations of a builtin to specify calling convention.

[Reid Kleckner via Phabricator via cfe-commits]

rnk added inline comments.


================
Comment at: lib/Sema/SemaDecl.cpp:3144
+          << FunctionType::getNameForCallConv(NewTypeInfo.getCC())
+          << 3 /*on builtin function*/;
+      NewTypeInfo = NewTypeInfo.withCallingConv(OldTypeInfo.getCC());
----------------
You can make these self-documenting with an enum, and then reference the enum name in a comment in the .td file. It seems the existing convention is to put these types of enums directly into the Sema class.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59560/new/

https://reviews.llvm.org/D59560