[PATCH] D59520: [WebAssembly] Address review comments on r352930

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.

I love functional changes that remove code and add tests -- thank you for these!

> Removes errnoneous use of diag::err_alias_is_definition, which turned out to be ineffective anyway since functions can be defined later in the translation unit and avoid detection.

If you need to keep the prohibition that these attributes not be applied to functions with definitions, there are ways to accomplish that (we merge declarations and can decide what to do at that point if we see a declaration that is a definition). Given that, do you still want to lift this restriction?



================
Comment at: test/Sema/attr-wasm.c:3
+
+void name_a() {}
+
----------------
Was this intended to be used somewhere? Probably can just be removed if not.


================
Comment at: test/Sema/attr-wasm.c:15
+
+void module_a() {}
+
----------------
Same here.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59520/new/

https://reviews.llvm.org/D59520