[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

Tue Mar 19 03:20:28 PDT 2019

ilya-biryukov added a comment.

In D59302#1431274 <https://reviews.llvm.org/D59302#1431274>, @kadircet wrote:

> The optional part is rather limiting number of diagnostics that is going to be surfaced. So if you have thousands of errors inside preamble only first 100 of them will appear inside main file by default.
>  But looking at it again, currently there is no way for user to say "do not limit number of diagnostics" :D They can only change this limit to different values.

Let's pick a number and hard-code it. We'll get consistent behavior in all clients of clangd, I can hardly think of any existing client that would want to surface everything to the user.
FWIW, `100` seem too much to my taste, since we're only showing errors. Would `10` be a better limit?

Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59302/new/

https://reviews.llvm.org/D59302