[PATCH] D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows.

Tue Mar 19 00:05:45 PDT 2019

ikudrin marked an inline comment as done.
ikudrin added inline comments.

================
Comment at: test/Frontend/absolute-paths-windows.test:4
+// RUN: mkdir -p %t.dir\real
+// RUN: cmd /c mklink /j %t.dir\junc %t.dir\real
+// RUN: echo "wrong code" > %t.dir\real\foo.cpp
----------------
ikudrin wrote:
> hans wrote:
> > This requires (a recent version of) Win 10 or later to run without running as Admin, right?
> As far as I know, creating a directory junction, in contrast to a symbolic link, does not require escalated privileges. But, honestly, I do not have any old system to validate that.
We checked that on Windows 7. It does not require rights elevation, too.

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59415/new/

https://reviews.llvm.org/D59415