[PATCH] D59367: [Sema] Adjust address space of operands in remaining builtin operators
John McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Mar 18 21:33:59 PDT 2019
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
This patch LGTM.
You might consider adding tests for weird cases like class types with conversion operators to reference types. To a certain extent that sort of thing is unimplementable because the space of address spaces is infinite, so we can't fall back on adding a candidate for every possible address space; but even if we don't plan on addressing it, we can test our current behavior to check that we don't do something unexpected (like crash or give a nonsensical diagnostic).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59367/new/
https://reviews.llvm.org/D59367
More information about the cfe-commits
mailing list