[PATCH] D58160: MS ABI: adding template static member in the linker directive section to make sure init function can be called before main.

Mon Mar 18 11:03:29 PDT 2019

rnk added a comment.

Apparently I wrote this comment long ago and never hit send.

================
Comment at: lib/CodeGen/CGDeclCXX.cpp:484
     AddGlobalCtor(Fn, 65535, COMDATKey);
+    if (getTarget().getCXXABI().isMicrosoft()) {
+      // In The MS C++, MS add template static data member in the linker
----------------
We might really want isOSBinFormatCOFF, since I think the same issue affects Windows Itanium with -OPT:REF and LLD.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58160/new/

https://reviews.llvm.org/D58160