[PATCH] D59487: [Tooling] Add more scope specifiers until spelling is not ambiguous.

[Eric Liu via Phabricator via cfe-commits]

ioeric marked 2 inline comments as done.
ioeric added inline comments.


================
Comment at: lib/Tooling/Core/Lookup.cpp:165
+    if (UnspelledScopes.empty()) {
+      Disambiguated = "::" + Disambiguated;
+    } else {
----------------
kadircet wrote:
> maybe return or break afterwards?
I also struggled a bit here. But I decided to let `IsAmbiguousSpelling` handle it because it seemed a bit more natural. Otherwise, we would somewhat duplicate the logic that spelling with leading "::" is not ambiguous.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59487/new/

https://reviews.llvm.org/D59487