[PATCH] D59486: [OpenCL] Improve testing of default header in C++ mode

Mon Mar 18 08:50:07 PDT 2019

Anastasia marked an inline comment as done.
Anastasia added inline comments.

================
Comment at: test/Driver/include-default-header.cl:2
+// RUN: %clang -save-temps -x cl -Xclang -cl-std=CL2.0 -Xclang -finclude-default-header -emit-llvm -S -### %s 2>&1 | FileCheck %s
+// RUN: %clang -save-temps -x cl -Xclang -cl-std=c++ -Xclang -finclude-default-header -emit-llvm -S -### %s 2>&1 | FileCheck %s
+
----------------
bader wrote:
> According to my understanding test/Driver tests covers only driver component, i.e. all other components like Parser/Sema are not covered by these tests. AFAIK "-###" prints the commands generated by driver, but do not run them.
> Do we want to test parsing/Sema for OpenCL C++ mode or do you think that testing OpenCL C mode is enough?
I think testing Clang actions in C++ mode with default include is pointless since lang mode doesn't affect anything there. But testing in Sema is indeed what we should do. I have updated the patch now.

However, I am still fixing this test because it wasn't testing anything before.

Thanks for spotting this!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59486/new/

https://reviews.llvm.org/D59486